Skip to content

[Core] Fix aiohttp auto-headers - #6992

Merged
annatisch merged 3 commits into
masterfrom
annatisch-patch-3
Sep 5, 2019
Merged

[Core] Fix aiohttp auto-headers#6992
annatisch merged 3 commits into
masterfrom
annatisch-patch-3

Conversation

@annatisch

Copy link
Copy Markdown
Member

Currently aiohttp is automatically giving us a content-type header for Put/Post/Patch requests if one is not specified in the pipeline.
This behaviour is inconsistent with the requests transport.

@adxsdk6

adxsdk6 commented Aug 28, 2019

Copy link
Copy Markdown

Can one of the admins verify this patch?

@annatisch annatisch assigned rakshith91 and unassigned rakshith91 Aug 28, 2019
@annatisch

Copy link
Copy Markdown
Member Author

@rakshith91 - could you please sign off once you've confirm that this change resolves the tests issues in Storage (and doesn't cause any new ones!) :)

@annatisch
annatisch marked this pull request as ready for review August 29, 2019 23:11
@annatisch

Copy link
Copy Markdown
Member Author

@xiangyan99 is there a "preview3" branch that I should be PRing to rather than master?

@annatisch
annatisch merged commit 57297a7 into master Sep 5, 2019
@lmazuel
lmazuel deleted the annatisch-patch-3 branch October 9, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants